-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating configure
according to the MobX docs
#237
Conversation
According to the latest react course and the [docs](https://github.com/mobxjs/mobx/blob/master/CHANGELOG.md#510--440) of mobx, `configure({ enforceActions: true })` has been changed to be `configure({ enforceActions: 'observed' })` it takes multi kind of values depending to the use case But our use case case is the `'observed'` one.
@Jawhar-B Why not |
@isaachinman thanks for reply and sorry being late, you are right it make more sense even for me. it's not a one teacher I heard they are more than that, when ever they arrive to this point they are not even sure if MobX will work with out of it. by putting this thing here we are enforcing the teacher and the student to have a look on what is this and why is it exactly. |
Hi @Jawhar-B, I don't think I understand your comment 100%. In regards to I don't think I understand the use case of unobserved observables, but this should probably be set to |
I will Just re-describe what I mentioned before with the Comment that Michel wrote there:
I am totally sure that you have your point of using Now according to what is in the documentation that the observed value is the recommended one, And as an addition ~> this comment is just a kind of briefly describing what each is doing.
going back to the docs we find that they said on the
which Improving your point exactly as it is. But as I pointed out before, this addition from me only to make the teacher(s) after you with no intend maybe search (for now) a bit more and understand why is it like so (according to the closure principle I think), and introduce it's work better than before, that will make the student more aware of it and he will got his own benefit by knowing the two others. I don't think we still have a lot of time introducing more about MobX and React in our docs here while Class16 have React class the current Sunday 💔 Plus But I didn't totally understand this comment:
Any future plans or maybe surprises are we expecting? |
Nice catch. I did not see this in the updated docs. If this is the case, what you've suggested here is correct.
Yes, the decorator syntax is changing a bit right now. This is not specific to MobX, but Michel is obviously aware of it and making changes in v6. If you need help changing the curriculum let me know. |
Thanks a lot for help, and yes of course I will 🙂 |
According to the latest react course and the docs of mobx,
configure({ enforceActions: true })
has been changed to beconfigure({ enforceActions: 'observed' })
it takes multi kind of values depending to the use case But our use case case is the'observed'
one.